1
0
mirror of https://github.com/spl0k/supysonic.git synced 2024-09-19 10:51:04 +00:00

Add compatibility shims for Python 2.7

- `os.scandir` (provided by a 3rd party package in 2.7)
- `os.replace` (doesn't exist in 2.7 - have to use `os.rename` instead)
- `os.utime` (the times param is required in 2.7)
This commit is contained in:
Carey Metcalfe 2019-01-17 03:45:50 -05:00
parent 65d49a04c9
commit 3db489aa7b
3 changed files with 31 additions and 3 deletions

View File

@ -22,6 +22,7 @@ reqs = [
'Pillow', 'Pillow',
'requests>=1.0.0', 'requests>=1.0.0',
'mutagen>=1.33', 'mutagen>=1.33',
'scandir<2.0.0',
'zipstream' 'zipstream'
] ]
extras = { extras = {

View File

@ -18,6 +18,8 @@ import tempfile
import threading import threading
from time import time from time import time
from .py23 import scandir, osreplace
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
@ -73,7 +75,7 @@ class Cache(object):
self._size = 0 self._size = 0
self._files = OrderedDict() self._files = OrderedDict()
for mtime, size, key in sorted([(f.stat().st_mtime, f.stat().st_size, f.name) for mtime, size, key in sorted([(f.stat().st_mtime, f.stat().st_size, f.name)
for f in os.scandir(self._cache_dir) for f in scandir(self._cache_dir)
if f.is_file()]): if f.is_file()]):
self._files[key] = CacheEntry(size, mtime + self.min_time) self._files[key] = CacheEntry(size, mtime + self.min_time)
self._size += size self._size += size
@ -110,7 +112,7 @@ class Cache(object):
"""Touch the file to change modified time and move it to the end of the cache dict""" """Touch the file to change modified time and move it to the end of the cache dict"""
old = self._files.pop(key) old = self._files.pop(key)
self._files[key] = CacheEntry(old.size, int(time()) + self.min_time) self._files[key] = CacheEntry(old.size, int(time()) + self.min_time)
os.utime(self._filepath(key)) os.utime(self._filepath(key), None)
@property @property
def size(self): def size(self):
@ -165,7 +167,7 @@ class Cache(object):
with self._lock: with self._lock:
if self._auto_prune: if self._auto_prune:
self._make_space(size, key=key) self._make_space(size, key=key)
os.replace(f.name, self._filename(key)) osreplace(f.name, self._filepath(key))
self._record_file(key, size) self._record_file(key, size)
except OSError as e: except OSError as e:
# Ignore error from trying to delete the renamed temp file # Ignore error from trying to delete the renamed temp file

View File

@ -7,6 +7,31 @@
# #
# Distributed under terms of the GNU AGPLv3 license. # Distributed under terms of the GNU AGPLv3 license.
# Try built-in scandir, fall back to the package for Python 2.7
try:
from os import scandir
except ImportError:
from scandir import scandir
# os.replace was added in Python 3.3, provide a fallback for Python 2.7
try:
from os import replace as osreplace
except ImportError:
# os.rename is equivalent to os.replace except on Windows
# On Windows an existing file will not be overwritten
# This fallback just attempts to delete the dst file before using rename
import sys
if sys.platform != 'win32':
from os import rename as osreplace
else:
import os
def osreplace(src, dst):
try:
os.remove(dst)
except OSError:
pass
os.rename(src, dst)
try: try:
# Python 2 # Python 2
strtype = basestring strtype = basestring